Skip to content

Document support for http.HTTPMethod in the @action decorator added in Python 3.11. #9067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 15, 2023
Merged

Document support for http.HTTPMethod in the @action decorator added in Python 3.11. #9067

merged 2 commits into from
Aug 15, 2023

Conversation

@pavelkraleu
Copy link
Contributor

@pavelkraleu pavelkraleu commented Aug 11, 2023

This pull request ensures that the http.HTTPMethod added in Python 3.11 is fully supported in the @action decorator, as mentioned in issue #8995.

Description

Only one test and documentation update is needed, since http.HTTPMethod already functions as is.

The reason for this is that @action already invokes lower() on each method, which converts http.HTTPMethod to a str a format that is already supported.

action

auvipy
auvipy reviewed Aug 13, 2023
View reviewed changes
Copy link
Collaborator

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my thoughts on this is, do django support this structs as of yet?

@pavelkraleu
Copy link
Contributor Author

pavelkraleu commented Aug 14, 2023

my thoughts on this is, do django support this structs as of yet?

That is a very good question.

I have not found any use of http.HTTPMethod in Django.
But for example request.method used in Django returns HTTP method in upper case which is compatible with http.HTTPMethod.

>>> HTTPMethod.GET == "GET"
True

So I think we can say yes, Django supports http.HTTPMethod 🙂

auvipy
auvipy requested changes Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm still reluctant to at this right now before knowing the decisions of other maintainers

@auvipy auvipy requested a review from a team August 15, 2023 04:36
pauloxnet
pauloxnet approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@pauloxnet pauloxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auvipy auvipy changed the title Implement support for http.HTTPMethod, which was added in Python 3.11, in the @action Document support for http.HTTPMethod in the @action decorator added in Python 3.11 Aug 15, 2023
@auvipy auvipy changed the title Document support for http.HTTPMethod in the @action decorator added in Python 3.11 Document support for http.HTTPMethod in the @action decorator added in Python 3.11. Aug 15, 2023
@auvipy auvipy merged commit a47adbc into encode:master Aug 15, 2023
@auvipy auvipy added this to the 3.15 milestone Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@auvipy auvipy auvipy approved these changes

+1 more reviewer

@pauloxnet pauloxnet pauloxnet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Documentation Enhancement

Projects

None yet

Milestone

3.15

Development

Successfully merging this pull request may close these issues.

3 participants

@pavelkraleu @pauloxnet @auvipy